Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Ignore .md file changes when deciding whether to run the all_solutions jobs. #1984

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

tippmar-nr
Copy link
Member

Minor update to ignore changes to .md files, there's no need to run the all_solutions build if that's the only file that was changed.

@chynesNR
Copy link
Member

Isn't a successful build required before merging? Or will that not apply here?

@tippmar-nr
Copy link
Member Author

@chynesNR The workflow considers itself "successful" if there's nothing to do.

@tippmar-nr
Copy link
Member Author

... although now I'm starting to wonder why it's running the full build on this PR - maybe I didn't get the globbing correct.

@tippmar-nr tippmar-nr merged commit 8e7ea98 into main Oct 17, 2023
14 checks passed
@tippmar-nr tippmar-nr deleted the ci/ignore-md-changes branch October 17, 2023 19:59
@tippmar-nr tippmar-nr restored the ci/ignore-md-changes branch October 17, 2023 20:18
@tippmar-nr
Copy link
Member Author

This PR completed before I was ready and didn't really make the change it purports to. I'll be opening a new PR once I figure out the correct incantations...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants