Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature work/kafka - Revise byte count metric #1987

Merged

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Oct 17, 2023

Exposes a RecordByteMetric() method on IAgentExperimental that reports a "proper" byte count metric that allows the NR UI to do it's magic for avg/sum/etc.

Also adds Kafka to the ArtifactBuilder components lists.

@tippmar-nr
Copy link
Member Author

@nrcventura Appreciate if you'd take a look when you get time!

Copy link
Member

@nrcventura nrcventura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a better way to track the bytes metric so that all of the timeslice fields are populated. We should probably add some unit tests to cover the new code.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (feature/kafka-instrumentation@ae55b61). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                       Coverage Diff                        @@
##             feature/kafka-instrumentation    #1987   +/-   ##
================================================================
  Coverage                                 ?   83.29%           
================================================================
  Files                                    ?      403           
  Lines                                    ?    24770           
  Branches                                 ?        0           
================================================================
  Hits                                     ?    20631           
  Misses                                   ?     4139           
  Partials                                 ?        0           

@tippmar-nr tippmar-nr merged commit ad2217d into feature/kafka-instrumentation Oct 18, 2023
11 checks passed
@tippmar-nr tippmar-nr deleted the feature-work/kafka-more-metrics branch October 18, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants