-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature work/kafka - Revise byte count metric #1987
Feature work/kafka - Revise byte count metric #1987
Conversation
@nrcventura Appreciate if you'd take a look when you get time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a better way to track the bytes metric so that all of the timeslice fields are populated. We should probably add some unit tests to cover the new code.
Codecov Report
@@ Coverage Diff @@
## feature/kafka-instrumentation #1987 +/- ##
================================================================
Coverage ? 83.29%
================================================================
Files ? 403
Lines ? 24770
Branches ? 0
================================================================
Hits ? 20631
Misses ? 4139
Partials ? 0 |
Exposes a
RecordByteMetric()
method onIAgentExperimental
that reports a "proper" byte count metric that allows the NR UI to do it's magic for avg/sum/etc.Also adds Kafka to the ArtifactBuilder components lists.