Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**DRAFT** fix: Better null handling during ASP.NET Core 6+ browser agent injection. #2037

Closed
wants to merge 2 commits into from

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Nov 8, 2023

Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.

Description

Adds additional null handling and exception handling code for ASP.NET Core 6+ browser agent injection.
Also adds additional checking as early as possible to short-circuit around the browser injection if we aren't supposed to inject the script due to configuration or response content type and path.

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@codecov-commenter
Copy link

Codecov Report

Merging #2037 (575b9c9) into main (ca96d0c) will decrease coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2037      +/-   ##
==========================================
- Coverage   81.07%   81.04%   -0.04%     
==========================================
  Files         394      394              
  Lines       24667    24671       +4     
  Branches     2962     2963       +1     
==========================================
- Hits        20000    19994       -6     
- Misses       3883     3893      +10     
  Partials      784      784              
Files Coverage Δ
src/Agent/NewRelic/Agent/Core/Agent.cs 70.64% <0.00%> (-0.93%) ⬇️

... and 3 files with indirect coverage changes

@tippmar-nr tippmar-nr changed the title **DRAFT** fix: Better null handling during ASP.NET Core 6+ browser agent injection. #2035 **DRAFT** fix: Better null handling during ASP.NET Core 6+ browser agent injection. Nov 8, 2023
@tippmar-nr tippmar-nr closed this Nov 8, 2023
@tippmar-nr tippmar-nr deleted the fix/browser-injection-null-handling branch November 8, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants