Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add integration tests for Audit logging. #2108

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

tippmar-nr
Copy link
Member

Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.

Description

Adds integration tests for Audit logging. Primarily just validates that the logfile exists and contains the expected number of sent and received lines.

Resolves #2030

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@codecov-commenter
Copy link

Codecov Report

Merging #2108 (3ba30d2) into main (d4e505b) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2108      +/-   ##
==========================================
- Coverage   81.10%   81.07%   -0.03%     
==========================================
  Files         395      395              
  Lines       24711    24711              
  Branches     2969     2969              
==========================================
- Hits        20041    20035       -6     
- Misses       3886     3890       +4     
- Partials      784      786       +2     

see 1 file with indirect coverage changes

@tippmar-nr tippmar-nr enabled auto-merge (squash) November 30, 2023 20:12
@tippmar-nr tippmar-nr merged commit 924765b into main Nov 30, 2023
@tippmar-nr tippmar-nr deleted the test/audit-log-integration-tests branch November 30, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration tests for Audit Logging
4 participants