Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Upgrade Release Please to v4 #2128

Merged
merged 6 commits into from
Dec 8, 2023
Merged

ci: Upgrade Release Please to v4 #2128

merged 6 commits into from
Dec 8, 2023

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Dec 8, 2023

Upgrades Release Please to version 4. Resolves #2124

Adds a release-please/release-please-config.json file that maps configuration options previously given on the command line of the release-please workflow. The release-please/.release-please-manifest.json file seems to be required for the initial run and will be ignored on future releases. I think.

Also uses the sentence-case plugin, which will capitalize the leading word in a commit message, taking into account common exceptions, e.g., gRPC.

Tested locally (running via NodeJs) and on a dry-run, generated output that exactly matches the current release please PR:

10.20.1 (2023-12-08)

Fixes

  • Fix a crash that can occur when the profiler logs certain characters. (#1982) (#2109) (742d232)
  • Improve handling of .NET environments and settings from appsettings.*.json files (#2125) (3c21fe9)
  • Obfuscate logged appSettings values (#2110) (2d8da68)
  • Revert RabbitMQ HandleBasicDeliver instrumentation change from #1972. Resolves #2047 (#2118) (0525182)
  • Update instrumentation to support Elasticsearch v8.11.0 (#2100) (9effb5d)

This PR was generated with Release Please. See documentation.

@codecov-commenter
Copy link

Codecov Report

Merging #2128 (ec3e556) into main (3c21fe9) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2128      +/-   ##
==========================================
+ Coverage   81.05%   81.07%   +0.02%     
==========================================
  Files         395      395              
  Lines       24724    24724              
  Branches     2970     2970              
==========================================
+ Hits        20040    20046       +6     
+ Misses       3898     3894       -4     
+ Partials      786      784       -2     

see 1 file with indirect coverage changes

@tippmar-nr tippmar-nr enabled auto-merge (squash) December 8, 2023 17:25
Copy link
Member

@nr-ahemsath nr-ahemsath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tippmar-nr tippmar-nr merged commit 2443c91 into main Dec 8, 2023
74 checks passed
@tippmar-nr tippmar-nr deleted the ci/release-please-v4 branch December 8, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants