-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Upgrade Release Please to v4 #2128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chynesNR
reviewed
Dec 8, 2023
chynesNR
approved these changes
Dec 8, 2023
jaffinito
approved these changes
Dec 8, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2128 +/- ##
==========================================
+ Coverage 81.05% 81.07% +0.02%
==========================================
Files 395 395
Lines 24724 24724
Branches 2970 2970
==========================================
+ Hits 20040 20046 +6
+ Misses 3898 3894 -4
+ Partials 786 784 -2 |
nr-ahemsath
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
nrcventura
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades Release Please to version 4. Resolves #2124
Adds a
release-please/release-please-config.json
file that maps configuration options previously given on the command line of the release-please workflow. Therelease-please/.release-please-manifest.json
file seems to be required for the initial run and will be ignored on future releases. I think.Also uses the
sentence-case
plugin, which will capitalize the leading word in a commit message, taking into account common exceptions, e.g., gRPC.Tested locally (running via NodeJs) and on a dry-run, generated output that exactly matches the current release please PR:
10.20.1 (2023-12-08)
Fixes
This PR was generated with Release Please. See documentation.