-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Skip testing deprecated non-async client methods in latest Elastic.Clients.Elasticsearch versions #2569
Merged
nr-ahemsath
merged 5 commits into
main
from
tests/remove-deprecated-elasticsearch-methods
Jun 22, 2024
Merged
tests: Skip testing deprecated non-async client methods in latest Elastic.Clients.Elasticsearch versions #2569
nr-ahemsath
merged 5 commits into
main
from
tests/remove-deprecated-elasticsearch-methods
Jun 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nr-ahemsath
requested review from
a team,
jaffinito,
nrcventura,
chynesNR,
tippmar-nr and
dotnet-agent-team-bot
June 20, 2024 22:52
tippmar-nr
reviewed
Jun 21, 2024
...iFunctionApplicationHelpers/NetStandardLibraries/Elasticsearch/ElasticsearchElasticClient.cs
Outdated
Show resolved
Hide resolved
tippmar-nr
reviewed
Jun 21, 2024
...ultiFunctionApplicationHelpers/NetStandardLibraries/Elasticsearch/ElasticsearchTestClient.cs
Outdated
Show resolved
Hide resolved
tippmar-nr
reviewed
Jun 21, 2024
tests/Agent/IntegrationTests/UnboundedIntegrationTests/Elasticsearch/ElasticsearchTests.cs
Show resolved
Hide resolved
nrcventura
reviewed
Jun 21, 2024
tests/Agent/IntegrationTests/UnboundedIntegrationTests/Elasticsearch/ElasticsearchTests.cs
Show resolved
Hide resolved
tippmar-nr
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2569 +/- ##
==========================================
+ Coverage 80.59% 80.86% +0.26%
==========================================
Files 459 458 -1
Lines 28927 28985 +58
Branches 3177 3184 +7
==========================================
+ Hits 23315 23439 +124
+ Misses 4822 4756 -66
Partials 790 790
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest Elastic.Clients.Elasticsearch versions, non-async methods are deprecated. We previously ignored the deprecation warnings and continued testing these methods. This PR:
Connect
andGenerateError
methods to be "async all the way" in order to usePingSync()
instead ofPing()
for those methods.This also introduces the use of a 3rd-party library
XUnit.SkippableFact
to skip tests based on runtime conditions. I wanted to be explicit that we were skipping test cases rather than just having them pass without actually testing anything.