Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS-APM Entity Relatipnships: SQS #2635

Merged

Conversation

tippmar-nr
Copy link
Member

Adds additional attributes to enable SQS entity relationships to be formed. Includes unit and integration test updates.

@tippmar-nr tippmar-nr requested a review from a team as a code owner July 17, 2024 19:10
@tippmar-nr tippmar-nr enabled auto-merge (squash) July 17, 2024 19:18
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.88%. Comparing base (334937d) to head (6152b5a).

Additional details and impacted files
@@                        Coverage Diff                        @@
##           feature/apm-aws-relationships    #2635      +/-   ##
=================================================================
+ Coverage                          80.81%   80.88%   +0.06%     
=================================================================
  Files                                459      459              
  Lines                              29064    29101      +37     
  Branches                            3191     3198       +7     
=================================================================
+ Hits                               23488    23537      +49     
+ Misses                              4787     4770      -17     
- Partials                             789      794       +5     
Flag Coverage Δ
Agent 81.80% <100.00%> (+0.07%) ⬆️
Profiler 72.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...gent/Core/Attributes/AttributeDefinitionService.cs 95.40% <100.00%> (+0.13%) ⬆️
...ic/Agent/Core/Segments/MessageBrokerSegmentData.cs 95.55% <100.00%> (+2.45%) ⬆️
...nt/NewRelic/Agent/Core/Transactions/Transaction.cs 80.50% <100.00%> (ø)
...ions/NewRelic.Agent.Extensions/AwsSdk/SqsHelper.cs 90.32% <100.00%> (+28.02%) ⬆️

... and 3 files with indirect coverage changes

@tippmar-nr tippmar-nr merged commit dda9380 into feature/apm-aws-relationships Jul 17, 2024
90 checks passed
@tippmar-nr tippmar-nr deleted the feature-work/sqs-entity-relationships branch July 17, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants