Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Kafka bootstrap servers cache wasn't implemented correctly #2657

Merged

Conversation

tippmar-nr
Copy link
Member

The Producer and Consumer are both generics, so just using the type name wasn't sufficient; we'll cache on the full Type now instead.

@tippmar-nr tippmar-nr requested a review from a team as a code owner July 31, 2024 16:31
@tippmar-nr tippmar-nr enabled auto-merge (squash) July 31, 2024 16:32
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (d57a875) to head (98b9347).

Additional details and impacted files
@@                      Coverage Diff                       @@
##           feature/apm-aws-relationships    #2657   +/-   ##
==============================================================
  Coverage                          80.89%   80.89%           
==============================================================
  Files                                459      459           
  Lines                              29102    29102           
  Branches                            3198     3198           
==============================================================
  Hits                               23543    23543           
  Misses                              4767     4767           
  Partials                             792      792           
Flag Coverage Δ
Profiler 72.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tippmar-nr tippmar-nr merged commit 8d1e774 into feature/apm-aws-relationships Jul 31, 2024
23 checks passed
@tippmar-nr tippmar-nr deleted the feature-work/kafka-bug-fix branch July 31, 2024 16:42
@tippmar-nr tippmar-nr restored the feature-work/kafka-bug-fix branch July 31, 2024 20:54
@tippmar-nr tippmar-nr deleted the feature-work/kafka-bug-fix branch July 31, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants