Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auto-instrument ASP.NET Core Lambda functions #2674

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

tippmar-nr
Copy link
Member

Enables automatic instrumentation for ASP.NET Core Lambda functions. Includes the following Lambda function classes:

  • Amazon.Lambda.AspNetCoreServer.APIGatewayProxyFunction
  • Amazon.Lambda.AspNetCoreServer.APIGatewayHttpApiV2ProxyFunction
  • Amazon.Lambda.AspNetCoreServer.ApplicationLoadBalancerFunction

Includes integration tests that validate correct instrumentation.

Closes #2662

@tippmar-nr tippmar-nr requested a review from a team as a code owner August 6, 2024 21:20
chynesNR
chynesNR previously approved these changes Aug 6, 2024
Copy link
Member

@chynesNR chynesNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@tippmar-nr tippmar-nr requested a review from chynesNR August 7, 2024 15:05
@tippmar-nr tippmar-nr enabled auto-merge (squash) August 7, 2024 15:05
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.73%. Comparing base (c3faea2) to head (6610a5b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2674   +/-   ##
=======================================
  Coverage   80.72%   80.73%           
=======================================
  Files         459      459           
  Lines       29070    29070           
  Branches     3191     3191           
=======================================
+ Hits        23467    23469    +2     
+ Misses       4812     4811    -1     
+ Partials      791      790    -1     
Flag Coverage Δ
Agent 81.72% <ø> (+<0.01%) ⬆️
Profiler 71.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@tippmar-nr tippmar-nr merged commit ceaefc5 into main Aug 7, 2024
101 checks passed
@tippmar-nr tippmar-nr deleted the feature/lambda-aspnetcore-autoinstrumentation branch August 7, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lambda: Add auto-instrumentation for ASP.NET Core functions
3 participants