Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SQSRequestHandler.cs - Fix 2811 #2816

Closed
wants to merge 1 commit into from

Conversation

indy-singh
Copy link

This quick fixes dynamically pulling out a property see #2811

@indy-singh indy-singh requested a review from a team as a code owner October 7, 2024 19:55
@CLAassistant
Copy link

CLAassistant commented Oct 7, 2024

CLA assistant check
All committers have signed the CLA.

@nr-ahemsath
Copy link
Member

Thank you for submitting a PR. At first glance, your changes make sense. However, on our end we need to do some more research to understand how this scenario can occur, and come up with a reliable reproduction case. Thank your for your patience while we do the analysis.

@indy-singh
Copy link
Author

Hi @nr-ahemsath,

It will be an empty ReceiveMessageResponse, so the scenario is the queue was polled but it had no messages to action. So an empty response T was received. Depending on how the consumer has configured their AWS SDK; the collection on T is either empty or null.

https://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API_ReceiveMessage.html#API_ReceiveMessage_ResponseElements

https://github.com/aws/aws-sdk-net/blob/b5c10d5d48299f6c68286ee48039bc4ecbc21019/sdk/src/Services/SQS/Generated/Model/ReceiveMessageResponse.cs#L37

Happy to close the PR, if you guys want to deep dive on it.

Cheers,
Indy

@nr-ahemsath
Copy link
Member

@indy-singh Thanks for the additional info, that will be very helpful. We're happy to leave the PR open for now.

@nr-ahemsath
Copy link
Member

@indy-singh Thanks again for the initial take on this fix. This PR has a more complete version of the fix, plus testing: #2833

Will close this one now.

@indy-singh indy-singh deleted the issue-2811 branch October 14, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants