feat: Enable DynamoDB entity relationships #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b.com/newrelic/newrelic-dotnet-agent into feature/invoke-lambda-instrumentation
…ation' into feature/dynamodb-entity-relationship
Base automatically changed from
feature/invoke-lambda-instrumentation
to
main
January 15, 2025 20:51
tippmar-nr
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2923 +/- ##
==========================================
+ Coverage 81.70% 81.79% +0.08%
==========================================
Files 467 470 +3
Lines 29800 29949 +149
Branches 3315 3327 +12
==========================================
+ Hits 24349 24496 +147
- Misses 4659 4660 +1
- Partials 792 793 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nrcventura
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for building the ARM for DynamoDB which is necessary to enable the entity relationship. The required attributes (
cloud.resource_id,aws.operationandaws.region) are added to the DynamoDB Datastore segment.A notable change in this PR is that the AWS Account ID is cached per instance of the
ClientConfigobject, which is a property ofAmazonServiceClientand is passed as a property in every pipeline invocation. This allows us to support a different Account ID for different AWS services.In this implementation, the
AwsAccountIdconfiguration value is only used if there is an error while parsing the account ID from the credentials passed to theAmazonServiceClientconstructor, or if theClientConfigobject isn't in the cache for some reason.