Remove references to System.Data.Odbc from wrapper and extensions #2928
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per team pairing last week, we should not add a reference to
System.Data.Odbc
to theSql
wrapper project nor theExtensions
project with the helper code.I initially went down a rabbit hole of using visibility bypasser to get the necessary data out of the
OdbcCommand
object. However, I eventually realized that we can treat theOdbcCommand
object as anIDbCommand
interface type and get almost everything we need directly that way. The one exception is theDriver
string (needed to get the DatastoreVendor), which is not a part of theIDbCommand
interface. However, it can be easily parsed from the ODBC connection string (and cached based on the full connection string).