Merge pull request #2197 from newrelic/fix-httpclient-5-memory-issue

Fix memory issue with httpclient-5.0 instrumentation
newrelic · Jan 14, 2025 · 22bd258 · 22bd258
2 parents 2c2422a + 4919640
commit 22bd258
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/...t-5.0/src/main/java/org/apache/hc/client5/http/async/HttpAsyncClient_Instrumentation.java b/...t-5.0/src/main/java/org/apache/hc/client5/http/async/HttpAsyncClient_Instrumentation.java
@@ -41,6 +41,8 @@ public <T> Future<T> execute(
         Segment segment = InstrumentationUtils.startAsyncSegment();
 
         HttpRequest request = ((BasicRequestProducer_Instrumentation)requestProducer).nrRequest;
+        // null out the NewField to prevent memory issues
+        ((BasicRequestProducer_Instrumentation)requestProducer).nrRequest = null;
         InstrumentationUtils.doOutboundCAT(request, segment);
         Token token = NewRelic.getAgent().getTransaction().getToken();
 

diff --git a/.../main/java/org/apache/hc/core5/http/nio/support/BasicRequestProducer_Instrumentation.java b/.../main/java/org/apache/hc/core5/http/nio/support/BasicRequestProducer_Instrumentation.java
@@ -17,7 +17,7 @@
 public class BasicRequestProducer_Instrumentation {
 
     @NewField
-    public final HttpRequest nrRequest;
+    public HttpRequest nrRequest;
 
     public BasicRequestProducer_Instrumentation(final HttpRequest request, final AsyncEntityProducer dataProducer) {
         nrRequest = request;