undo adding DT for SQS sdk v1 #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2217 +/- ##
=========================================
Coverage 70.57% 70.58%
- Complexity 9973 9977 +4
=========================================
Files 842 842
Lines 40374 40374
Branches 6119 6119
=========================================
+ Hits 28492 28496 +4
+ Misses 9105 9102 -3
+ Partials 2777 2776 -1 ☔ View full report in Codecov by Sentry. |
meiao
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
undo changes in the previous PR to support distributed tracing for SQS V1 SDK.
The reason here is the v1 sdk id deprecated, Amazon will no longer be support v1 APIs by the end of 2025, and the verifier failed.
Related Github Issue
#2036