Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Updated unit tests to use node:test #282

Merged

Conversation

svetlanabrennan
Copy link
Contributor

@svetlanabrennan svetlanabrennan commented Dec 9, 2024

Description

Removed tap and replaced with node:test.

How to Test

Run npm run unit.

Related Issues

Closes issue #279
Partially fixes issue #280 (for unit test script)

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.59%. Comparing base (869e524) to head (3ee289c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #282   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files           1        1           
  Lines         166      166           
=======================================
  Hits          162      162           
  Misses          4        4           
Flag Coverage Δ
integration-tests-18-ubuntu-latest-x64 88.55% <ø> (ø)
integration-tests-18-windows-latest-x64 88.55% <ø> (ø)
integration-tests-18-windows-latest-x86 88.55% <ø> (ø)
integration-tests-20-ubuntu-latest-x64 88.55% <ø> (ø)
integration-tests-20-windows-latest-x64 88.55% <ø> (ø)
integration-tests-20-windows-latest-x86 88.55% <ø> (ø)
integration-tests-22-ubuntu-latest-x64 88.55% <ø> (ø)
integration-tests-22-windows-latest-x64 88.55% <ø> (ø)
integration-tests-22-windows-latest-x86 88.55% <ø> (ø)
unit-tests-18-ubuntu-latest-x64 97.59% <ø> (ø)
unit-tests-18-windows-latest-x64 97.59% <ø> (ø)
unit-tests-18-windows-latest-x86 97.59% <ø> (ø)
unit-tests-20-ubuntu-latest-x64 97.59% <ø> (ø)
unit-tests-20-windows-latest-x64 97.59% <ø> (ø)
unit-tests-20-windows-latest-x86 97.59% <ø> (ø)
unit-tests-22-ubuntu-latest-x64 97.59% <ø> (ø)
unit-tests-22-windows-latest-x64 97.59% <ø> (ø)
unit-tests-22-windows-latest-x86 97.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package.json Outdated Show resolved Hide resolved
tests/unit/gc-metrics.test.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@svetlanabrennan svetlanabrennan marked this pull request as ready for review December 9, 2024 21:25
Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Just a couple of comments around, uh, comments.

tests/unit/gc-metrics.test.js Outdated Show resolved Hide resolved
tests/unit/loop-metrics.test.js Outdated Show resolved Hide resolved
@@ -8,7 +8,7 @@
"lint": "eslint .",
"lint:fix": "eslint . --fix",
"lint:lockfile": "lockfile-lint --path package-lock.json --type npm --allowed-hosts npm --validate-https --validate-integrity",
"unit": "c8 -o ./coverage/unit tap --expose-gc --jobs=1 --no-coverage tests/unit/*.tap.js",
"unit": "c8 -o ./coverage/unit borp --expose-gc --timeout 180000 'tests/unit/*.test.js'",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also addressing #280

@svetlanabrennan svetlanabrennan merged commit 7a53a19 into newrelic:main Dec 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants