fix: Updated shimmer to allow registering instrumentation for different versions of the same module #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1799 +/- ##
==========================================
- Coverage 96.84% 96.83% -0.02%
==========================================
Files 198 199 +1
Lines 38755 38959 +204
==========================================
+ Hits 37531 37724 +193
- Misses 1224 1235 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bizob2828
force-pushed
the
allow-inst-multiple-versions
branch
from
20a80eb to
794fed4
Compare
…nt versions of the same module
bizob2828
force-pushed
the
allow-inst-multiple-versions
branch
from
794fed4 to
b762bd9
Compare
mrickard
approved these changes
Oct 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We never had a test that tried to instrument the same package on different versions. This was a regression in v10 when we moved indicators of if instrumentation ran from module to the instrumentation hook. I also took the time to update an error message to indicate if an instrumentation hook was skipped because it failed or already ran. I also updated shimmer to include a few missing test cases. Also this PR will set us up for shifting registering instrumentation based on versions from the hook itself to shimmer(future change).
Links
Closes #1798