Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added configuration for openai instrumentation #1856

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

jsumners-nr
Copy link
Contributor

@jsumners-nr jsumners-nr commented Nov 9, 2023

The PR adds the configuration described in #1848 and resolves #1848.

I found some basic configuration testing, but it looks like there are not any tests that test for specific configuration items.

lib/config/default.js Outdated Show resolved Hide resolved
@jsumners-nr jsumners-nr requested a review from bizob2828 November 9, 2023 15:43
bizob2828
bizob2828 previously approved these changes Nov 9, 2023
Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #1856 (05f5d9f) into main (1b93ec9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1856   +/-   ##
=======================================
  Coverage   96.83%   96.83%           
=======================================
  Files         200      200           
  Lines       39073    39074    +1     
=======================================
+ Hits        37838    37839    +1     
  Misses       1235     1235           
Flag Coverage Δ
integration-tests-16.x 78.96% <100.00%> (+<0.01%) ⬆️
integration-tests-18.x 79.22% <100.00%> (+0.01%) ⬆️
integration-tests-20.x 79.22% <100.00%> (-0.02%) ⬇️
unit-tests-16.x 91.35% <100.00%> (+<0.01%) ⬆️
unit-tests-18.x 91.33% <100.00%> (+<0.01%) ⬆️
unit-tests-20.x 91.33% <100.00%> (+<0.01%) ⬆️
versioned-tests-16.x 73.15% <100.00%> (-0.01%) ⬇️
versioned-tests-18.x 73.15% <100.00%> (-0.01%) ⬇️
versioned-tests-20.x 73.16% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/feature_flags.js 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@jsumners-nr jsumners-nr requested a review from bizob2828 November 9, 2023 17:10
@@ -5,17 +5,10 @@

'use strict'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@bizob2828 bizob2828 changed the title feat: add openai configuration feat: Added configuration for openai instrumentation Nov 9, 2023
@jsumners-nr jsumners-nr merged commit 08b5a78 into newrelic:main Nov 9, 2023
22 checks passed
@jsumners-nr jsumners-nr deleted the issue-1848 branch November 9, 2023 17:12
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

OpenAI configuration updates
2 participants