-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added configuration for openai instrumentation #1856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work
Codecov Report
@@ Coverage Diff @@
## main #1856 +/- ##
=======================================
Coverage 96.83% 96.83%
=======================================
Files 200 200
Lines 39073 39074 +1
=======================================
+ Hits 37838 37839 +1
Misses 1235 1235
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
@@ -5,17 +5,10 @@ | |||
|
|||
'use strict' | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻
The PR adds the configuration described in #1848 and resolves #1848.
I found some basic configuration testing, but it looks like there are not any tests that test for specific configuration items.