test: Fixed shadowed variable lint error in pino versioned tests #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes a lint error complaining about a "logger" variable being redeclared in a subtest. Here, we refactor the tests to use variables from the subtest private context to avoid any potential side effects between tests and remove the lint error.
Codecov Report
@@ Coverage Diff @@
## main #1859 +/- ##
=======================================
Coverage 96.83% 96.83%
=======================================
Files 200 200
Lines 39074 39074
=======================================
Hits 37839 37839
Misses 1235 1235
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
bizob2828
approved these changes
Nov 10, 2023
bizob2828
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a lint error complaining about a "logger" variable being redeclared in a subtest. Here, we refactor the tests to use variables from the subtest private context to avoid any potential side effects between tests and remove the lint error.