Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ai_monitoring configuration #1873

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

jsumners-nr
Copy link
Contributor

This change resolves #1866 by removing the previously added feature flag and replacing it with the ai_monitoring configuration directive.

This change resolves newrelic#1866 by removing the previously added
feature flag and replacing it with the ai_monitoring configuration
directive.
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34dcd70) 96.85% compared to head (4e419ac) 96.87%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1873      +/-   ##
==========================================
+ Coverage   96.85%   96.87%   +0.01%     
==========================================
  Files         208      209       +1     
  Lines       39422    39589     +167     
==========================================
+ Hits        38184    38351     +167     
  Misses       1238     1238              
Flag Coverage Δ
integration-tests-16.x 78.77% <100.00%> (-0.19%) ⬇️
integration-tests-18.x 79.04% <100.00%> (-0.17%) ⬇️
integration-tests-20.x 79.05% <100.00%> (-0.18%) ⬇️
unit-tests-16.x 91.16% <100.00%> (-0.09%) ⬇️
unit-tests-18.x 91.14% <100.00%> (-0.09%) ⬇️
unit-tests-20.x 91.14% <100.00%> (-0.09%) ⬇️
versioned-tests-16.x 73.58% <100.00%> (+0.27%) ⬆️
versioned-tests-18.x 73.58% <100.00%> (+0.27%) ⬆️
versioned-tests-20.x 73.59% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on test

@jsumners-nr jsumners-nr merged commit 52bf9f3 into newrelic:main Nov 16, 2023
21 checks passed
@jsumners-nr jsumners-nr deleted the issue-1866 branch November 16, 2023 15:49
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

OpenAI configuration updates - part 2
2 participants