Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add version tracking metric on OpenAI events #1882

Closed
wants to merge 3 commits into from

Conversation

jsumners-nr
Copy link
Contributor

This resolves #1847.

Note: we need branch https://github.com/bizob2828/node-newrelic/tree/instrument-completion-stream merged and this to be rebased before we can merge.

Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slight tweak but looks like it does the job

@@ -165,6 +165,7 @@ const EXPRESS = {
}

const AI = {
TRACKING_PREFIX: 'Nodejs/ML/OpenAI/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd omit OpenAI as the prefix is technically Nodejs/ML.

@jsumners-nr
Copy link
Contributor Author

jsumners-nr commented Nov 27, 2023

I'm closing this one because:

  1. It really needs to be based off feat: Added instrumentation for chat completion streams #1884 once it has been merged
  2. I created a mess for myself trying to juggle the various branches and repos with worktrees

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Library metric on embedding/chat completion
2 participants