Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a set of flaky tests on macOS. I think the problem is due to the way macOS file system does things. This answer indicates that access times are wonky on APFS to begin with. I tried several variations to try and fudge the time of file creation and then verification, but I always ended up with a failure. Sometimes it would take a couple of seconds to hit the error, other times it would take a minute or so. Regardless, it always fails on macOS when trying to test the modified access time.
I do not have a Linux or Windows system available for work to verify any of these guesses, though. So it could be a flake that we are just lucky doesn't hit in CI.
For what it's worth, I verified my attempts with:
Also, I opened a discussion to try and get some more insight. Maybe someone will answer with information that let's us properly fix this.