feat: Added segment synthesis for otel producer spans #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2839 +/- ##
=======================================
Coverage 97.35% 97.36%
=======================================
Files 303 304 +1
Lines 47141 47194 +53
=======================================
+ Hits 45896 45949 +53
Misses 1245 1245
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jsumners-nr
approved these changes
Dec 16, 2024
bizob2828
added a commit
that referenced
this pull request
Dec 19, 2024
bizob2828
added a commit
that referenced
this pull request
Jan 13, 2025
bizob2828
added a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I updated the rules engine to handle producer spans separate from client spans as they are different. Currently there's only one producer rule which is a fallback rule. I think this is because the messaging spec is most complete and takes a few span attributes to build the name.
Related Issues
Closes #2650