Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added segment synthesis for internal spans #2840

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

bizob2828
Copy link
Member

Description

This one is straightforward, pull the name of span to name segment but prefix with Custom/

Related Issues

Closes #2652

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.78%. Comparing base (483cafe) to head (af42866).
Report is 1 commits behind head on next.

❗ There is a different number of reports uploaded between BASE (483cafe) and HEAD (af42866). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (483cafe) HEAD (af42866)
unit-tests-22.x 1 0
unit-tests-20.x 1 0
unit-tests-18.x 1 0
integration-tests-cjs-22.x 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2840      +/-   ##
==========================================
- Coverage   97.36%   88.78%   -8.58%     
==========================================
  Files         304      296       -8     
  Lines       47194    46693     -501     
==========================================
- Hits        45949    41457    -4492     
- Misses       1245     5236    +3991     
Flag Coverage Δ
integration-tests-cjs-18.x 73.21% <ø> (ø)
integration-tests-cjs-20.x 73.22% <ø> (+<0.01%) ⬆️
integration-tests-cjs-22.x ?
integration-tests-esm-18.x 49.87% <ø> (ø)
integration-tests-esm-20.x 49.87% <ø> (ø)
integration-tests-esm-22.x 49.92% <ø> (ø)
unit-tests-18.x ?
unit-tests-20.x ?
unit-tests-22.x ?
versioned-tests-18.x 79.15% <ø> (ø)
versioned-tests-20.x 79.16% <ø> (ø)
versioned-tests-22.x 79.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizob2828 bizob2828 merged commit 359a266 into next Dec 17, 2024
49 of 50 checks passed
@bizob2828 bizob2828 deleted the internal-spans-to-segments branch December 17, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants