chore: Added Node.js 24 support #3080

jsumners-nr · 2025-05-06T16:12:37Z

This PR resolves #3095 and also resolves #3096.

All smoke tests are passing for me locally.

bizob2828 · 2025-05-06T21:35:49Z

Just a FYI you'll have to run smoke tests and security versioned tests locally as they aren't getting invoked here. I can help you with the smoke tests in the morning as they require some env vars to be set

codecov · 2025-05-07T12:24:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.59%. Comparing base (51b82aa) to head (d01bdfb).
Report is 14 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #3080       +/-   ##
===========================================
+ Coverage   80.40%   97.59%   +17.18%     
===========================================
  Files         329      339       +10     
  Lines       49792    51023     +1231     
===========================================
+ Hits        40037    49796     +9759     
+ Misses       9755     1227     -8528

Flag	Coverage Δ
integration-tests-cjs-18.x	`73.91% <100.00%> (?)`
integration-tests-cjs-20.x	`73.90% <100.00%> (?)`
integration-tests-cjs-22.x	`73.94% <100.00%> (?)`
integration-tests-cjs-24.x	`74.58% <100.00%> (?)`
integration-tests-esm-18.x	`49.65% <0.00%> (-0.02%)`	⬇️
integration-tests-esm-20.x	`49.65% <0.00%> (-0.02%)`	⬇️
integration-tests-esm-22.x	`49.72% <0.00%> (?)`
integration-tests-esm-24.x	`51.33% <0.00%> (?)`
unit-tests-18.x	`88.35% <100.00%> (?)`
unit-tests-20.x	`88.35% <100.00%> (?)`
unit-tests-22.x	`88.35% <100.00%> (?)`
unit-tests-24.x	`88.35% <100.00%> (?)`
versioned-tests-18.x	`79.98% <100.00%> (-0.26%)`	⬇️
versioned-tests-20.x	`80.10% <100.00%> (-0.22%)`	⬇️
versioned-tests-22.x	`80.11% <100.00%> (-0.22%)`	⬇️
versioned-tests-24.x	`80.00% <100.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jsumners-nr · 2025-05-07T13:32:27Z

At least one blocker is newrelic/csec-node-agent#297

test/versioned/pg/package.json

bizob2828 · 2025-05-07T13:57:50Z

At least one blocker is newrelic/csec-node-agent#297

It's weird because it's just warning on leaking event emitters. Some fail if you run the entire suite at once because of tests getting canceled, but if you run the versioned tests and only specify a package that's failing it's fine

bizob2828 · 2025-05-12T16:16:28Z

It looks like in 24.0.1 the versioned tests that assert CLM attributes are now failing. This is done via @contrast/fn-inspect, I'm trying to build that project locally and it's failing

jsumners-nr · 2025-05-12T16:27:06Z

@contrast/fn-inspect

Their CI needs to be updated https://github.com/Contrast-Security-Inc/node-fn-inspect/blob/3062b379a4a3842389eccd56c2429b5952d8ea5f/.github/workflows/test.yml#L24

bizob2828 · 2025-05-12T17:08:10Z

@contrast/fn-inspect

Their CI needs to be updated https://github.com/Contrast-Security-Inc/node-fn-inspect/blob/3062b379a4a3842389eccd56c2429b5952d8ea5f/.github/workflows/test.yml#L24

Maybe, I've contributed to this project in the past as I've added support for 20 and 22. I'm trying to determine if my mac is messed up or 24 doesn't work

jsumners-nr · 2025-05-12T19:27:07Z

Blocker 2 -- Contrast-Security-Inc/node-fn-inspect#78

jsumners-nr · 2025-05-13T12:33:22Z

The suites I'm having issues with under v24.0.0 in combination with the security client, right now, are:

~~bluebird -- That's at least partially due to the issue linked above, I believe~~ -- test suite was taking roughly >= 78 seconds to run. This exceeded the time we allot to running single suites.
aws-sdk-v2 -- The "dax client" tests are flaky

bizob2828 · 2025-05-13T15:43:05Z

So when i run npm run versioned:security bluebird it times out on the methods.test.js in version 3.0.6. However, if I just run that file NEW_RELIC_SECURITY_AGENT_ENABLED=true node test/versioned/bluebird/methods.test.js it passes. The timeout on the test runner may have to be increased. I don't think the leaking of the event emitters has anything to do with it

bizob2828

verified benchmark, smoke tests and versioned tests + security agent are working on Node 24.

bizob2828 · 2025-06-25T19:40:07Z

test/versioned/restify/package.json

@@ -6,7 +6,8 @@
  "tests": [
    {
      "engines": {
-        "node": ">=18"
+        "node": ">=18 <24",
+        "comment": "https://github.com/restify/node-restify/issues/1984"


can you create a ticket to update this when restify makes a fix?

i see you signed off, i can log this

github-project-automation bot added this to Node.js Engineering Board May 6, 2025

newrelic-node-agent-team moved this to Needs PR Review in Node.js Engineering Board May 6, 2025

bizob2828 reviewed May 7, 2025

View reviewed changes

test/versioned/pg/package.json Outdated Show resolved Hide resolved

jsumners-nr force-pushed the node-24 branch from e43af3e to 3c2c0c6 Compare May 12, 2025 14:42

jsumners-nr changed the title ~~chore: Added Node.js 24 to CI jobs~~ chore: Added Node.js 24 support May 13, 2025

jsumners-nr force-pushed the node-24 branch from b7e0668 to 5faf77e Compare May 14, 2025 12:40

jsumners-nr added the force-smoke Run smoke tests on a pull request. label May 19, 2025

jsumners-nr force-pushed the node-24 branch from 5faf77e to 47c1a1a Compare May 22, 2025 17:04

jsumners-nr force-pushed the node-24 branch from 47c1a1a to 1074263 Compare June 11, 2025 16:47

jsumners-nr removed the force-smoke Run smoke tests on a pull request. label Jun 11, 2025

jsumners-nr marked this pull request as ready for review June 11, 2025 18:43

jsumners-nr force-pushed the node-24 branch from 1074263 to b8cd7e4 Compare June 12, 2025 11:30

jsumners-nr added 8 commits June 12, 2025 09:24

chore: Added Node.js 24 to CI jobs

166ce79

kick ci

8c5b8c2

fix index incrementation

34fb961

fix cassandra-driver issue

df24a17

disable restify and pg tests

1e8951c

split pg tests

e7d448d

add pg fix

5480cdd

refactor bluebird tests to avoid timeout

a6cbbe6

jsumners-nr added 2 commits June 12, 2025 09:24

update version check

e8ddd10

bump native-metrics

1e88685

jsumners-nr force-pushed the node-24 branch from b8cd7e4 to 1e88685 Compare June 12, 2025 13:25

jsumners-nr requested a review from bizob2828 June 12, 2025 16:36

bizob2828 self-assigned this Jun 12, 2025

swap fn-inspect

d01bdfb

bizob2828 approved these changes Jun 25, 2025

View reviewed changes

bizob2828 merged commit a538c2a into newrelic:main Jun 25, 2025
49 of 51 checks passed

github-project-automation bot moved this from Needs PR Review to Done: Issues recently completed in Node.js Engineering Board Jun 25, 2025

bizob2828 mentioned this pull request Jun 25, 2025

Unpin restify tests when it supports node 24 #3176

Open

jsumners-nr deleted the node-24 branch June 26, 2025 11:42

jsumners-nr mentioned this pull request Jun 26, 2025

Issues with Node 24 on main branch #3180

Closed

github-actions bot mentioned this pull request Jun 30, 2025

chore: release v12.23.0 #3189

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: Added Node.js 24 support #3080

chore: Added Node.js 24 support #3080

Uh oh!

jsumners-nr commented May 6, 2025 •

edited

Loading

Uh oh!

bizob2828 commented May 6, 2025

Uh oh!

codecov bot commented May 7, 2025 •

edited

Loading

Uh oh!

jsumners-nr commented May 7, 2025

Uh oh!

Uh oh!

bizob2828 commented May 7, 2025

Uh oh!

bizob2828 commented May 12, 2025

Uh oh!

jsumners-nr commented May 12, 2025

Uh oh!

bizob2828 commented May 12, 2025

Uh oh!

jsumners-nr commented May 12, 2025

Uh oh!

jsumners-nr commented May 13, 2025 •

edited

Loading

Uh oh!

bizob2828 commented May 13, 2025 •

edited

Loading

Uh oh!

bizob2828 left a comment

Uh oh!

bizob2828 Jun 25, 2025

Uh oh!

bizob2828 Jun 25, 2025

Uh oh!

Uh oh!

Uh oh!

chore: Added Node.js 24 support #3080

chore: Added Node.js 24 support #3080

Uh oh!

Conversation

jsumners-nr commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bizob2828 commented May 6, 2025

Uh oh!

codecov bot commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jsumners-nr commented May 7, 2025

Uh oh!

Uh oh!

bizob2828 commented May 7, 2025

Uh oh!

bizob2828 commented May 12, 2025

Uh oh!

jsumners-nr commented May 12, 2025

Uh oh!

bizob2828 commented May 12, 2025

Uh oh!

jsumners-nr commented May 12, 2025

Uh oh!

jsumners-nr commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bizob2828 commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bizob2828 left a comment

Choose a reason for hiding this comment

Uh oh!

bizob2828 Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

bizob2828 Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jsumners-nr commented May 6, 2025 •

edited

Loading

codecov bot commented May 7, 2025 •

edited

Loading

jsumners-nr commented May 13, 2025 •

edited

Loading

bizob2828 commented May 13, 2025 •

edited

Loading