Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v8 #10

Merged
merged 16 commits into from
Sep 25, 2024
Merged

Update to v8 #10

merged 16 commits into from
Sep 25, 2024

Conversation

asllop
Copy link
Contributor

@asllop asllop commented Sep 9, 2024

Update the tracker to make it compatible with Bitmovin v8.

@asllop asllop marked this pull request as draft September 9, 2024 12:43
@asllop asllop marked this pull request as ready for review September 17, 2024 13:39
@asllop
Copy link
Contributor Author

asllop commented Sep 17, 2024

KNOWN ISSUE

The AD_BREAK_END event is not sent. I've been investigating it and I think it's a problem in the video-core, not in the Bitmovin tracker. Other trackers have problems with the AD_BREAK events. We have to review the video-core code responsible of ad handling thoroughly.

EDIT: issue fixed, check this comment.

Copy link

@jpradhan-nr jpradhan-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are LGTM 👍

@asllop
Copy link
Contributor Author

asllop commented Sep 19, 2024

I think Bitmovin 8.181.0 (the latest version) has a bug with ad events reporting. First of all, I discovered an issue that makes the JS execution abort when we try to obtain the ad position, using the following code:

this.player.ads.getActiveAdBreak().position

This was what made the AD_BREAK_END event not to fire (reported in the previous comment) and I had to remove this code to fix the issue. So now we can't obtain the adPosition attribute. But I also discovered another problem, and there is no workaround for it. If the stream has more than one ad block, the first one (the pre-roll) works fine. But in the next one (the mid-roll), adStarted and adFinished events aren't reported by the player, but all other events are. Without these two player events we can't fire the AD_START and AD_END video events.

@asllop asllop merged commit 5f4ea08 into master Sep 25, 2024
7 checks passed
@asllop asllop deleted the update_to_v8 branch September 25, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants