Skip to content

fix(pathJoin): Don't trim leading slash off the first argument #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(pathJoin): Don't trim leading slash off the first argument #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50cdd6c
Don't slice leading slash off the first argument
awesomephant Jul 27, 2025
e3506d4
Add test
awesomephant Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ai2html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,10 +999,13 @@ function applyTemplate(template, replacements) {
// Similar to Node.js path.join()
function pathJoin() {
var path = '';
forEach(arguments, function(arg) {
forEach(arguments, function(arg, i) {
if (!arg) return;
arg = String(arg);
arg = arg.replace(/^\/+/, '').replace(/\/+$/, '');
if (i > 0){
arg = arg.replace(/^\/+/, ''); // leading
}
arg = arg.replace(/\/+$/, ''); // trailing
if (path.length > 0) {
path += '/';
}
Expand Down
4 changes: 4 additions & 0 deletions test/utils-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,10 @@ describe('Utility function tests', function() {
it('removes duplicate slashes', function() {
assert.equal(lib.pathJoin('ai/', '/output/', 'image.svg'), 'ai/output/image.svg');
})

it('retains leading slash in first argument', function() {
assert.equal(lib.pathJoin('/c/', '/output/', 'image.svg'), '/c/output/image.svg');
})
})

describe('pathSplit()', function() {
Expand Down