fix(#1524): delete deprecated CacheFactory, migrate to CacheBrick#2454
Open
windoliver wants to merge 1 commit intodevelopfrom
Open
fix(#1524): delete deprecated CacheFactory, migrate to CacheBrick#2454windoliver wants to merge 1 commit intodevelopfrom
windoliver wants to merge 1 commit intodevelopfrom
Conversation
…eBrick CacheFactory was deprecated per Issue #1524 — CacheBrick is the canonical replacement. Delete factory.py (365 LOC), remove all re-exports and references, migrate e2e tests to CacheBrick, and clean up dead record_store parameter from CacheBrick.__init__.
Contributor
Type Safety Progress 📉Current: 418 type: ignore comments ✅ Progress! Keep eliminating type suppressions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CacheFactoryclass (365 LOC) andfactory.py— superseded byCacheBrickper Issue refactor: Extract Cache module (~4,405 LOC) into Cache Brick #1524CacheFactoryfrom__init__.pyre-exports and__all__CacheBrickdocstrings: remove "CacheFactory-compatible" referencesrecord_storeparameter fromCacheBrick.__init__(stored but never read)CacheFactorytoCacheBrickTestCacheFactoryPostgresFallbacktests (CacheFactory-specific behavior, not replicated in CacheBrick)embeddings.pydocstring to referenceCacheBrickStream: #14
Test plan
TestCacheBrickIntegration)CacheFactoryreferences in codebase