fix(#2286): add nexus.security to tier-neutral layer in import-linter#2455
Open
windoliver wants to merge 1 commit intodevelopfrom
Open
fix(#2286): add nexus.security to tier-neutral layer in import-linter#2455windoliver wants to merge 1 commit intodevelopfrom
windoliver wants to merge 1 commit intodevelopfrom
Conversation
nexus.security contains pure utility functions (prompt sanitizer, URL validator, output validator) with zero Nexus-internal dependencies. Its own __init__.py declares it "Tier-neutral security package". Formally register it in the import-linter layers config alongside nexus.contracts and nexus.lib so bricks can legitimately import from it.
Contributor
Type Safety Progress 📉Current: 418 type: ignore comments ✅ Progress! Keep eliminating type suppressions! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.
| Benchmark suite | Current: a6c2465 | Previous: 47412c2 | Ratio |
|---|---|---|---|
tests/benchmarks/test_core_operations.py::TestBlake3HashingBenchmarks::test_hash_1mb_content |
3977.9258794501798 iter/sec (stddev: 0.000006327511344586937) |
6603.145917940173 iter/sec (stddev: 0.000007410072053980514) |
1.66 |
tests/benchmarks/test_core_operations.py::TestBlake3HashingBenchmarks::test_hash_smart_1mb_content |
21226.849244194877 iter/sec (stddev: 0.0000023756089385929686) |
34099.54872660558 iter/sec (stddev: 0.0000010957338875135603) |
1.61 |
tests/benchmarks/test_service_delegation.py::TestAsyncDelegationOverhead::test_version_get_delegation |
5680.028404337809 iter/sec (stddev: 0.0022656673562020785) |
7957.539783610038 iter/sec (stddev: 0.001739169458356453) |
1.40 |
tests/benchmarks/test_service_delegation.py::TestAsyncDelegationOverhead::test_rebac_check_delegation |
6636.015543130753 iter/sec (stddev: 0.000021097221920817543) |
9133.753611567156 iter/sec (stddev: 0.000019756552545522996) |
1.38 |
tests/benchmarks/test_service_delegation.py::TestAsyncDelegationOverhead::test_mcp_list_mounts_delegation |
6702.67856530243 iter/sec (stddev: 0.000024381953804451476) |
9260.93481431103 iter/sec (stddev: 0.000025379325687133745) |
1.38 |
tests/benchmarks/test_service_delegation.py::TestAsyncDelegationOverhead::test_oauth_list_providers_delegation |
5635.968880271102 iter/sec (stddev: 0.002600093917940425) |
7634.806028436233 iter/sec (stddev: 0.0021415115937043604) |
1.35 |
tests/benchmarks/test_service_delegation.py::TestGatewayDelegationOverhead::test_gateway_rebac_check |
39257.964013712124 iter/sec (stddev: 0.0017957829008455374) |
55641.571970588935 iter/sec (stddev: 0.001539687675707864) |
1.42 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nexus.securityto the tier-neutral layer in import-linter config (alongsidenexus.contractsandnexus.lib)nexus.securitycontains only pure utility functions (prompt sanitizer, URL validator, output validator) with zero Nexus-internal dependencies__init__.pydeclares it "Tier-neutral security package — usable from any Nexus layer"nexus.bricks.workflows.actions) can legitimately import security utilitiesStream: #14
Test plan