fix(mcp): remove invalid kwargs from mount() + singleton MCPMountManager#2646
Open
windoliver wants to merge 1 commit intodevelopfrom
Open
fix(mcp): remove invalid kwargs from mount() + singleton MCPMountManager#2646windoliver wants to merge 1 commit intodevelopfrom
windoliver wants to merge 1 commit intodevelopfrom
Conversation
- Remove tier/context kwargs from manager.mount() call — MCPMountManager.mount() only accepts mount_config parameter - Cache MCPMountManager as singleton per MCPService instance to avoid re-creating manager (and losing mount state) on every operation
Contributor
Type Safety Progress 📉Current: 422 type: ignore comments ✅ Progress! Keep eliminating type suppressions! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.
| Benchmark suite | Current: f37bee5 | Previous: 30da0de | Ratio |
|---|---|---|---|
tests/benchmarks/test_core_operations.py::TestFileOperationBenchmarks::test_write_small_file |
234.63962508491775 iter/sec (stddev: 0.0008376761000696998) |
308.6777033785906 iter/sec (stddev: 0.0004416906054584609) |
1.32 |
tests/benchmarks/test_core_operations.py::TestFileOperationBenchmarks::test_read_small_file |
4181.91065258942 iter/sec (stddev: 0.00004041290909377515) |
22119.537635818244 iter/sec (stddev: 0.000009150145388643872) |
5.29 |
tests/benchmarks/test_core_operations.py::TestFileOperationBenchmarks::test_read_cached_file |
4407.286088609299 iter/sec (stddev: 0.00002757011026373213) |
22553.67225363441 iter/sec (stddev: 0.00000811768569045049) |
5.12 |
tests/benchmarks/test_core_operations.py::TestPermissionBenchmarks::test_permission_check_bulk_rust |
3997.750535382709 iter/sec (stddev: 0.0002669099658117026) |
5504.002659905066 iter/sec (stddev: 0.00000974807087378153) |
1.38 |
tests/benchmarks/test_core_operations.py::TestBulkOperationBenchmarks::test_read_bulk_10 |
1210.8661420113751 iter/sec (stddev: 0.00040869358086208907) |
1866.8296649145318 iter/sec (stddev: 0.000028622934463952593) |
1.54 |
tests/benchmarks/test_service_delegation.py::TestGatewayDelegationOverhead::test_gateway_metadata_get |
35219.19411862206 iter/sec (stddev: 0.00270785271585147) |
49912.11002902808 iter/sec (stddev: 0.001874386108561643) |
1.42 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tierandcontextkwargs frommanager.mount()call —MCPMountManager.mount()only acceptsmount_configparameter, passing extra kwargs caused TypeError at runtimeMCPMountManageras singleton perMCPServiceinstance to avoid re-creating the manager (and losing mount state) on every RPC callTest plan