feat: system deployment configs and remote profile stability fixes#2833
Draft
joezhoujinjing wants to merge 5 commits intodevelopfrom
Draft
feat: system deployment configs and remote profile stability fixes#2833joezhoujinjing wants to merge 5 commits intodevelopfrom
joezhoujinjing wants to merge 5 commits intodevelopfrom
Conversation
Contributor
Type Safety Progress 📉Current: 246 type: ignore comments ✅ Progress! Keep eliminating type suppressions! |
1 similar comment
Contributor
Type Safety Progress 📉Current: 246 type: ignore comments ✅ Progress! Keep eliminating type suppressions! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.
| Benchmark suite | Current: ad09786 | Previous: 8cca243 | Ratio |
|---|---|---|---|
tests/benchmarks/test_core_operations.py::TestFileOperationBenchmarks::test_write_small_file |
221.68556608081502 iter/sec (stddev: 0.0008691962125866247) |
300.78711742209896 iter/sec (stddev: 0.00047809087645420096) |
1.36 |
tests/benchmarks/test_core_operations.py::TestBulkOperationBenchmarks::test_write_batch_10 |
23.461121089275963 iter/sec (stddev: 0.0030734721102454003) |
39.188778970248656 iter/sec (stddev: 0.001138536110711972) |
1.67 |
tests/benchmarks/test_rebac_latency.py::TestL1CacheHit::test_l1_cache_hit_latency |
15958.558315800148 iter/sec (stddev: 0.00001131560409131075) |
29000.081830264273 iter/sec (stddev: 0.000003409453269809088) |
1.82 |
tests/benchmarks/test_service_delegation.py::TestAsyncDelegationOverhead::test_version_get_delegation |
6600.7851292749 iter/sec (stddev: 0.00002940146060308673) |
8930.124477576594 iter/sec (stddev: 0.00003489369801859649) |
1.35 |
tests/benchmarks/test_service_delegation.py::TestAsyncDelegationOverhead::test_rebac_check_delegation |
6523.788186304292 iter/sec (stddev: 0.000023151291799368986) |
8769.424929753402 iter/sec (stddev: 0.000028394751338990928) |
1.34 |
tests/benchmarks/test_service_delegation.py::TestAsyncDelegationOverhead::test_rebac_list_tuples_with_param_rename |
4366.948632303901 iter/sec (stddev: 0.005603763535782478) |
5991.9709151156485 iter/sec (stddev: 0.004511562646146052) |
1.37 |
tests/benchmarks/test_service_delegation.py::TestAsyncDelegationOverhead::test_mcp_list_mounts_delegation |
6771.8583007818515 iter/sec (stddev: 0.00002787017971784442) |
8921.993016840954 iter/sec (stddev: 0.00003357628815439365) |
1.32 |
This comment was automatically generated by workflow using github-action-benchmark.
joezhoujinjing
force-pushed
the
feat/system-deployment-configs
branch
from
49436aa to
ad09786
Compare
Contributor
Type Safety Progress 📉Current: 246 type: ignore comments ✅ Progress! Keep eliminating type suppressions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables reliable, always-on Nexus operation by providing system-level daemon configurations and fixing critical bugs in the Remote Profile transport.
Changes:
deployment/macoswithlaunchdplist template andINSTALL.md.RemoteServiceProxyto inherit fromRPCProxyBase.listmethod toMETHOD_REGISTRYto ensure correct response unwrapping for SearchService calls.nexus ls /using Remote Mode over gRPC (Port 2028).These changes are essential for the upcoming Feishu WebSocket Gateway, ensuring the CLI remains functional while the server holds the metastore lock.