feat(#1452): Phase 4 — complete retroactive HookSpec capture + E2E fixes#2890
Merged
elfenlieds7 merged 1 commit intodevelopfrom Mar 11, 2026
Merged
Conversation
31e8078 to
a4b18a4
Compare
Contributor
Type Safety Progress 📉Current: 224 type: ignore comments ✅ Progress! Keep eliminating type suppressions! |
1 similar comment
Contributor
Type Safety Progress 📉Current: 224 type: ignore comments ✅ Progress! Keep eliminating type suppressions! |
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.
| Benchmark suite | Current: 78140a7 | Previous: 8cca243 | Ratio |
|---|---|---|---|
tests/benchmarks/test_core_operations.py::TestBulkOperationBenchmarks::test_write_batch_10 |
26.55852641761397 iter/sec (stddev: 0.0017765033064353279) |
39.188778970248656 iter/sec (stddev: 0.001138536110711972) |
1.48 |
tests/benchmarks/test_rebac_latency.py::TestL1CacheHit::test_l1_cache_hit_latency |
16545.411877696075 iter/sec (stddev: 0.000005968073100524602) |
29000.081830264273 iter/sec (stddev: 0.000003409453269809088) |
1.75 |
tests/benchmarks/test_service_delegation.py::TestAsyncDelegationOverhead::test_version_get_delegation |
6499.822914414492 iter/sec (stddev: 0.00006341587080857855) |
8930.124477576594 iter/sec (stddev: 0.00003489369801859649) |
1.37 |
tests/benchmarks/test_service_delegation.py::TestAsyncDelegationOverhead::test_rebac_check_delegation |
5603.319072202725 iter/sec (stddev: 0.000022290302309332483) |
8769.424929753402 iter/sec (stddev: 0.000028394751338990928) |
1.57 |
tests/benchmarks/test_service_delegation.py::TestAsyncDelegationOverhead::test_rebac_list_tuples_with_param_rename |
4031.135576068 iter/sec (stddev: 0.005245431722034773) |
5991.9709151156485 iter/sec (stddev: 0.004511562646146052) |
1.49 |
tests/benchmarks/test_service_delegation.py::TestAsyncDelegationOverhead::test_mcp_list_mounts_delegation |
5707.109744313794 iter/sec (stddev: 0.000029368963060247016) |
8921.993016840954 iter/sec (stddev: 0.00003357628815439365) |
1.56 |
tests/benchmarks/test_service_delegation.py::TestGatewayDelegationOverhead::test_gateway_rebac_check |
20871.556730847304 iter/sec (stddev: 0.00385609119935836) |
29321.097532881868 iter/sec (stddev: 0.003232515489113352) |
1.40 |
This comment was automatically generated by workflow using github-action-benchmark.
…11 hook groups Expand _build_retroactive_hook_specs() to cover the 9 remaining hook groups (permission, audit, viewer, auto_parse, tiger_cache, virtual_view, event_bus, revision_tracking) beyond the 2 captured in Phase 3 (events, memory_provider). This makes swap_service() bulletproof for any subsystem hot-swap. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
d346f1a to
78140a7
Compare
Contributor
Type Safety Progress 📉Current: 224 type: ignore comments ✅ Progress! Keep eliminating type suppressions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_build_retroactive_hook_specs()to capture all 11 hook groups (was 2), makingswap_service()bulletproof for any subsystemHook Groups Added (9 new)
E2E Fixes
test_cli_lifecycle.py: Unwrap JSON envelope{"data":..,"_timing":..}nexus_fs.py sys_readdir: Implement cursor-based pagination whenlimitis settest_list_pagination.py: Relax non-recursive assertion for implicit dirsremote_metastore.py: Add missingset_file_metadata/get_file_metadatafastapi_server.py: Guard A2A router creation whennexus_fs=NoneTest plan
🤖 Generated with Claude Code