fix(core): adjust userinfo endpoint validation on oauth callback #12669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@matusca96 is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
|
Can someone take a look on this? It's an annoying issue that requires us to provide |
|
@ThangHuuVu can you take a look on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
One line change on
packages/core/src/lib/actions/callback/oauth/callback.tsto always rely on authorization server (as). This change is necessary because since we don't requireuserinfoandtokenendpoints if anissueris provided, as perpackages/core/src/lib/utils/assert.ts, we can retrieve both endpoints directly from the authorization server.🧢 Checklist
🎫 Affected issues
📌 Resources