-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing issuer to discord provider config #12694
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@jariz is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should be in the provider config by default as the provider does not work at all without adding this right now.
I just tested on https://next-auth-example.vercel.app/ and it works fine. Discord is configured here: https://github.com/nextauthjs/next-auth-example/blob/f2754cf5f37f100e126284702fbd1e6cc75e5afa/auth.ts#L68
and here:
next-auth/apps/proxy/api/[auth].ts
Line 46 in 887c28c
Discord, |
I don' necessarily mind moving Discord to OIDC as I see there is a valid openid configuration at https://discord.com/.well-known/openid-configuration now, but it will require more changes than just adding an issuer.
Take the LinkedIn config for instance as a starting point, and feel free to update this PR: https://github.com/nextauthjs/next-auth/blob/main/packages/core/src/providers/linkedin.ts
@balazsorban44 when the current config stops working is if users request the |
☕️ Reasoning
The discord provider currently doesn't work out of the box and needs the issuer to be manually added like so:
I believe this should be in the provider config by default as the provider does not work at all without adding this right now.
🧢 Checklist
🎫 Affected issues
Fixes: #12687
📌 Resources