Skip to content

Comments

ci: run psalm stets with lowest compatible ocp-package#534

Closed
blizzz wants to merge 1 commit intomasterfrom
fix/noid/run-psalm-with-lowest-compat-server
Closed

ci: run psalm stets with lowest compatible ocp-package#534
blizzz wants to merge 1 commit intomasterfrom
fix/noid/run-psalm-with-lowest-compat-server

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Apr 24, 2025

  • for apps the run against one major version per branch nothing changes
  • for apps that are compatible with multiple apps, the lowest common determinator has to be used. E.g. it fails hard against deprecations.

- for apps the run against one major version per branch nothing changes
- for apps that are compatible with multiple apps, the lowest common
  determinator has to be used. E.g. it fails hard against deprecations.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added the 3. to review Waiting for reviews label Apr 24, 2025
@nickvergessen
Copy link
Member

If an app supports multiple branches it should use psalm-matrix.yml?
https://github.com/nextcloud/.github/blob/master/workflow-templates/psalm-matrix.yml

@blizzz
Copy link
Member Author

blizzz commented Apr 24, 2025

If an app supports multiple branches it should use psalm-matrix.yml? https://github.com/nextcloud/.github/blob/master/workflow-templates/psalm-matrix.yml

if it is unbroken again

@blizzz
Copy link
Member Author

blizzz commented Apr 24, 2025

If an app supports multiple branches it should use psalm-matrix.yml? https://github.com/nextcloud/.github/blob/master/workflow-templates/psalm-matrix.yml

if it is unbroken again

yeah, is. would not hurt anyway, but then the benefit aint great either 🤷 i'll close hence

@blizzz blizzz closed this Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants