Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ActivityTab): vertically center empty content #1733

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

edward-ly
Copy link
Contributor

Fixes an issue from a design review for another app that was recently brought to my attention: -- 8 comments app: The ‘No activity’ text and logo is too close to the input line. Some space is needed.

Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
Copy link

cypress bot commented Jul 18, 2024

1 failed test on run #1735 ↗︎

1 9 0 0 Flakiness 0

Details:

fix(ActivityTab): vertically center empty content
Project: Activity Commit: 75391f152d
Status: Failed Duration: 03:17 💡
Started: Jul 22, 2024 3:44 PM Ended: Jul 22, 2024 3:47 PM
Failed  cypress/e2e/sidebar.cy.ts • 1 failed test • Run E2E

View Output

Test Artifacts
Check activity listing in the sidebar > Has comment activity Test Replay Screenshots

Review all test suite changes for PR #1733 ↗︎

Copy link
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! :)
Can you also add before/after screenshots?

src/views/ActivityTab.vue Outdated Show resolved Hide resolved
Co-authored-by: Louis <louis@chmn.me>
Signed-off-by: Edward Ly <contact@edward.ly>
@edward-ly
Copy link
Contributor Author

edward-ly commented Jul 22, 2024

Thanks ! :) Can you also add before/after screenshots?

Sorry, I forgot about that, although I am having trouble getting the comments app to behave as expected on my end.

This is a screenshot that was provided to me by @marcelklehr:
20240717_085232

And here is the before and after from my setup.

Before After
Screenshot 2024-07-22 at 08-08-51 Files - Nextcloud Screenshot 2024-07-22 at 08-10-06 Files - Nextcloud

Signed-off-by: Edward Ly <contact@edward.ly>
@artonge
Copy link
Collaborator

artonge commented Jul 22, 2024

Red CI is unrelated, merging.

@artonge artonge merged commit 70362c1 into master Jul 22, 2024
46 of 50 checks passed
@artonge artonge deleted the fix/center-empty-content branch July 22, 2024 16:13
Copy link
Contributor

github-actions bot commented Aug 2, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants