Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some visual bugs #1741

Closed
wants to merge 2 commits into from

Conversation

Jerome-Herbinet
Copy link
Member

Tests from reviewers needed.

Before

Capture d’écran du 2024-07-31 11-55-55
Capture d’écran du 2024-07-31 11-57-38

After

Capture d’écran du 2024-07-31 11-56-02
Capture d’écran du 2024-07-31 11-57-42

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@Jerome-Herbinet
Copy link
Member Author

I'm quite surprised by the number of changed and committed files after npm run build.
Tell me if it's OK and can somebody test it ?

Copy link

cypress bot commented Jul 31, 2024



Test summary

9 1 0 0Flakiness 1


Run details

Project Activity
Status Failed
Commit f4e3ed8
Started Jul 31, 2024 10:13 AM
Ended Jul 31, 2024 10:15 AM
Duration 02:50 💡
OS Linux Ubuntu -
Browser Electron 118

View run in Cypress Cloud ➡️


Failures

cypress/e2e/sidebar.cy.ts Failed
1 Check activity listing in the sidebar > Has tag activity

Flakiness

cypress/e2e/sidebar.cy.ts Flakiness
1 Check activity listing in the sidebar > Has comment activity

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@Jerome-Herbinet
Copy link
Member Author

I realize that it's all fixed in NC 30.0.0 beta 2

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant