Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add sharing activity for teams #1754

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 24, 2024

This adds support for Teams (previously "Circles"), the user notification already work, but the notification for the owner and sharer need support in the files_sharing app.

So if this is merged we can add the required providers in files_sharing.

But one thing to mention: For groups we paginate the members, I did not find a nice way to do this with teams.
So maybe @ArtificialOwl can have a look at the member query if there is something to improve performance wise (e.g. pagination?).

Copy link

cypress bot commented Aug 24, 2024

Activity    Run #2157

Run Properties:  status check failed Failed #2157  •  git commit 77ce8ecacb: feat: Add sharing activity for teams
Project Activity
Branch Review feat/activity-for-team-share
Run status status check failed Failed #2157
Run duration 01m 16s
Commit git commit 77ce8ecacb: feat: Add sharing activity for teams
Committer Ferdinand Thiessen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 8
Tests that passed  Passing 0
View all changes introduced in this branch ↗︎

Tests for review

Failed  sidebar.cy.ts • 1 failed test • Run E2E

View Output

Test Artifacts
Check activity listing in the sidebar > Has creation activity Test Replay Screenshots
Failed  settings.cy.ts • 1 failed test • Run E2E

View Output

Test Artifacts
Check that user's settings survive a reload > Form survive a reload Test Replay Screenshots

Copy link
Collaborator

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@susnux susnux force-pushed the feat/activity-for-team-share branch 4 times, most recently from b69f982 to 2295c86 Compare August 31, 2024 12:32
@susnux
Copy link
Contributor Author

susnux commented Aug 31, 2024

TIL: protected (Foo&Bar)|Baz $variable does not work with PHP 8.1 but only 8.2 😅
(was in the test like: protected (Class&MockObject)|null $variable )

lib/FilesHooks.php Outdated Show resolved Hide resolved
lib/FilesHooks.php Outdated Show resolved Hide resolved
lib/FilesHooks.php Show resolved Hide resolved
@susnux susnux force-pushed the feat/activity-for-team-share branch from 0e06c4f to af98881 Compare January 17, 2025 07:44
@susnux susnux requested a review from artonge January 21, 2025 15:10
This adds support for Teams (previously "Circles"),
the user notification already work, but the notification for the owner
and sharer need support in the `files_sharing` app.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/activity-for-team-share branch from af98881 to af19269 Compare January 21, 2025 15:10
@susnux susnux linked an issue Jan 21, 2025 that may be closed by this pull request
@artonge artonge merged commit 51ee743 into master Jan 23, 2025
50 of 52 checks passed
@artonge artonge deleted the feat/activity-for-team-share branch January 23, 2025 09:20
@susnux
Copy link
Contributor Author

susnux commented Jan 23, 2025

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

Activity notifications
5 participants