-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add sharing activity for teams #1754
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b5c753a
to
0efac00
Compare
Activity
|
Project |
Activity
|
Branch Review |
feat/activity-for-team-share
|
Run status |
|
Run duration | 01m 16s |
Commit |
|
Committer | Ferdinand Thiessen |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
2
|
|
0
|
|
0
|
|
8
|
|
0
|
View all changes introduced in this branch ↗︎ |
Tests for review
sidebar.cy.ts • 1 failed test • Run E2E
Test | Artifacts | |
---|---|---|
Check activity listing in the sidebar > Has creation activity |
Test Replay
Screenshots
|
settings.cy.ts • 1 failed test • Run E2E
Test | Artifacts | |
---|---|---|
Check that user's settings survive a reload > Form survive a reload |
Test Replay
Screenshots
|
miaulalala
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b69f982
to
2295c86
Compare
TIL: |
2295c86
to
0e06c4f
Compare
This was referenced Jan 14, 2025
artonge
reviewed
Jan 16, 2025
artonge
reviewed
Jan 16, 2025
0e06c4f
to
af98881
Compare
This adds support for Teams (previously "Circles"), the user notification already work, but the notification for the owner and sharer need support in the `files_sharing` app. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
af98881
to
af19269
Compare
ArtificialOwl
approved these changes
Jan 22, 2025
/backport to stable31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Teams (previously "Circles"), the user notification already work, but the notification for the owner and sharer need support in the
files_sharing
app.So if this is merged we can add the required providers in
files_sharing
.But one thing to mention: For groups we paginate the members, I did not find a nice way to do this with teams.
So maybe @ArtificialOwl can have a look at the member query if there is something to improve performance wise (e.g. pagination?).