Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use composer-bin-plugin to manage dev deps #1785

Merged
merged 2 commits into from
Sep 15, 2024
Merged

chore: Use composer-bin-plugin to manage dev deps #1785

merged 2 commits into from
Sep 15, 2024

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Sep 14, 2024 •
edited
Loading

@artonge artonge added 2. developing dependencies Pull requests that update a dependency file labels Sep 14, 2024
@artonge artonge self-assigned this Sep 14, 2024
@cypress Cypress
Copy link

cypress bot commented Sep 14, 2024 •
edited
Loading

Activity    Run #1954

Run Properties:  status check passed Passed #1954  •  git commit af3072a24a: chore: Use composer-bin-plugin to manage dev deps
Project Activity
Branch Review artonge/use_composer_bin
Run status status check passed Passed #1954
Run duration 02m 43s
Commit git commit af3072a24a: chore: Use composer-bin-plugin to manage dev deps
Committer Louis
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 10
View all changes introduced in this branch ↗︎

@artonge
chore: Use composer-bin-plugin to manage dev deps
3389716 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
fix: Run cs:fix
7aa591a 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge added this to the Nextcloud 31 milestone Sep 14, 2024
come-nc
come-nc approved these changes Sep 15, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpunit should go in its own folder as well

@come-nc come-nc merged commit dd260cf into master Sep 15, 2024
54 checks passed
@come-nc come-nc deleted the artonge/use_composer_bin branch September 15, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

Assignees

@artonge artonge

Labels
3. to review dependencies Pull requests that update a dependency file php
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
2 participants
@artonge @come-nc