-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove requiring PNG for iOS #1793
Conversation
/backport to stable30 |
/backport to stable29 |
/backport to stable28 |
Activity Run #1971
Run Properties:
|
Project |
Activity
|
Branch Review |
require-png-ios
|
Run status |
Passed #1971
|
Run duration | 05m 20s |
Commit |
ce2efca11e: Remove requiring PNG for iOS
|
Committer | Milen Pivchev |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
10
|
View all changes introduced in this branch ↗︎ |
@mpivchev please fix DCO |
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Signed-off-by: Louis Chemineau <louis@chmn.me> Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
543ba40
to
a6808ab
Compare
/backport 7b7d464 to stable30 |
/backport 7b7d464 to stable29 |
/backport 7b7d464 to stable28 |
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/1793/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7b7d4645
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1793/stable30 Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/1793/stable30."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/1793/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7b7d4645
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1793/stable29 Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/1793/stable29."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/1793/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7b7d4645
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1793/stable28 Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/1793/stable28."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
PNGs sent are low quality, and iOS supports SVGs being sent.