Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containers-schema: allow to specify ui-secret and show in aio interface #5945

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

containers-schema: allow to specify ui-secret and show in aio interface #5945

wants to merge 2 commits into from
+42 −4

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Jan 23, 2025

Close #5938

@szaimen szaimen added 2. developing Work in progress enhancement New feature or request labels Jan 23, 2025
@szaimen szaimen added this to the next milestone Jan 23, 2025
@szaimen szaimen mentioned this pull request Jan 23, 2025
Open
33 tasks
@szaimen szaimen force-pushed the enh/5938/show-secret-in-interface branch 2 times, most recently from d81e046 to 1d4aeb2 Compare January 23, 2025 15:35
@szaimen szaimen force-pushed the enh/5938/show-secret-in-interface branch from 1d4aeb2 to 04ef456 Compare January 23, 2025 15:41
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 23, 2025
@szaimen szaimen marked this pull request as ready for review January 23, 2025 15:42
@szaimen szaimen requested review from docjyJ and ernolf January 23, 2025 15:42
@szaimen
Copy link
Collaborator Author

szaimen commented Jan 23, 2025

@docjyJ I think this is probably also interesting for you. Please review :)

docjyJ
docjyJ requested changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@docjyJ docjyJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Somme sugest:

  1. Update LLDAP json, Stalwart Readme/Json, NocoDB Readme/Json
  2. Add field with hide/show (Ex: https://codepen.io/piyush-tapaniya/pen/PvWKKj)
  3. Add copy button (Ex: https://codepen.io/foxbeefly/pen/dyWbQgJ)

I have not enough time to do that now...

@szaimen
address review
2efeff2 
Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen szaimen mentioned this pull request Jan 24, 2025
Open
2 tasks
@szaimen
Copy link
Collaborator Author

szaimen commented Jan 24, 2025

Thanks for the review @docjyJ! :)

  • Update LLDAP json, Stalwart Readme/Json, NocoDB Readme/Json

I have adjusted all except the stalwart readme since that is in your repo...

Can we please do this in a follow-up?

I've created #5954 for that :)

@szaimen szaimen requested a review from docjyJ January 24, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernolf ernolf Awaiting requested review from ernolf

@docjyJ docjyJ Awaiting requested review from docjyJ

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

allow to define if a secret gets shown in the aio interface
2 participants
@szaimen @docjyJ