Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an easy security improvement (at least for users with Google Pixel 8 and later, which have the hardware for MTE).
Nextcloud doesn't have any explicit native code itself. But there are some libandroidx.graphics.path.so files in the APK, and also Android framework code that Nextcloud calls might have native code. All of that runs in the app's process, so opting in to MTE will cover that. Nextcloud parses potentially attacker controlled data, so enabling MTE is an easy defense-in-depth.
I've been running Nextcloud on a Pixel 8a with GrapheneOS and MTE force-enabled for a few months now without any issues.
Still, I recommend you to test this again on an MTE-compatible device (Pixel 8 and later), just to be sure :)
I'm only sending PRs for Files and Notes for Android, because those I use a lot and can (at)test.
I recommend you enable MTE for other Android apps (Talk, Deck) as well, and also for the Nextcloud iOS Files app.
For background on MTE, see: