Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications adjustments. DeployActions. Docs updates #25

Merged
merged 8 commits into from
Aug 2, 2023

Conversation

andrey18106
Copy link
Collaborator

@andrey18106 andrey18106 commented Jul 31, 2023

  • DeployActions interface
  • Notifications adjustments (receive dynamic parameters to build known subjects)
  • Write short docs about Notifications

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88
Copy link
Member

bigcat88 commented Aug 1, 2023

Why we need both subject and rich_subject , message and rich_message ?
What has higher priority? Can we simplify it ti be only rich_subject and rich_message, as I understand we can pass there usual strings and not only rich ones.

@andrey18106

@bigcat88
Copy link
Member

bigcat88 commented Aug 2, 2023

Merging this as nc_py_api PR needs this now

@bigcat88 bigcat88 merged commit 08b72fe into main Aug 2, 2023
20 checks passed
@bigcat88 bigcat88 deleted the deploy-actions-notifications branch August 2, 2023 11:07
bigcat88 added a commit to cloud-py-api/nc_py_api that referenced this pull request Aug 2, 2023
Related to this:
nextcloud/app_api#25

Added Notification API + start grouping APIs

---------

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants