-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExApp version check #29
Conversation
andrey18106
commented
Aug 2, 2023
•
edited
Loading
edited
- Resolve conflicts
- Merge into auth throttling PR first
Thoughts:
|
122f0dd
to
aed09a6
Compare
First solution:
Pros:
Cons:
|
Second solution:
Pros:
Cons:
|
All members of the admin group should be fine. It feels weird to automatically accept new scopes from an ExApp. It makes the scope system useless when an ExApp is updated manually outside of NC. Also, we could recommend not to manually update ExApps as it can lead to longer app downtimes (until an admin validates the new scopes). Also, it is very likely that the person who updates an ExApp manually is a NC admin and knows it's wise to check the "app settings v2" to validate new scopes. So even if the notification is not perfect and can be seen late, it's good enough for a use case that is not recommended. We can decide people updating ExApps manually should know what they are doing and it's fine if the workflow is not perfect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Till this got rewritten to new algo
Disable ExApp and send notifications to admins Added ExAppAdminNotifier Minor fixes
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
will fix tomorrow, need to extend nc_py_api by adding two new APIs for extra applications. In wait for #35 to fix test |
Resolves: #35. Return consistent ExApps list structure. --------- Signed-off-by: Alexander Piskun <bigcat88@icloud.com> Co-authored-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>