Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter preparation for occ command #518

Open
wants to merge 1 commit into
base: stable31
Choose a base branch
from

Conversation

R0Wi
Copy link
Member

@R0Wi R0Wi commented Feb 17, 2025

Notes

  • I was only able to reproduce this on NC31 (because I didn't find any NC32 compatible apps in the store, yet). So the base for this fix is stable31
  • I took the liberty of defaulting $this->config->getSystemValue('apps_paths') with [], because I found some errors in my logs when trying to uninstall an app (something like "foreach needs an array, string given ..."). This happens if app_paths is not set. getSystemValue will return an "empty" string in that case.
  • If possible, a testcase should be added for this. Maybe with any deployed app which is updated regularly? Note that the problem did not occur when doing the "test install"

* Fix for #517

Signed-off-by: Robin Windey <ro.windey@gmail.com>
@R0Wi R0Wi requested a review from oleksandr-nc February 17, 2025 20:43
@R0Wi R0Wi linked an issue Feb 17, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Issue when trying to install external app via appstore
1 participant