Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force height for descr and location #6706

Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix: force height for descr and location #6706

merged 1 commit into from
Feb 13, 2025

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Feb 11, 2025

the problem
Screenshot from 2025-02-11 16-21-20

fixed

Screenshot from 2025-02-11 16-19-23

Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD added 3. to review Waiting for reviews bug labels Feb 11, 2025
@GretaD GretaD self-assigned this Feb 11, 2025
@GretaD GretaD marked this pull request as draft February 11, 2025 15:26
@GretaD GretaD marked this pull request as ready for review February 11, 2025 15:33
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.79%. Comparing base (7b81283) to head (832f86d).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/views/EditSidebar.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6706      +/-   ##
============================================
+ Coverage     23.02%   28.79%   +5.77%     
- Complexity      475      950     +475     
============================================
  Files           252      294      +42     
  Lines         12101    14391    +2290     
  Branches       2307     2308       +1     
============================================
+ Hits           2786     4144    +1358     
- Misses         8989     9921     +932     
  Partials        326      326              
Flag Coverage Δ
javascript 14.55% <0.00%> (ø)
php 59.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -109,6 +109,7 @@
:is-read-only="isReadOnly"
:prop-model="rfcProps.description"
:value="description"
:is-description="true"
Copy link
Contributor Author

@GretaD GretaD Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is needed, because when you click the textarea it jumbs to a smaller size, and i fixed it some time ago for simple editor and forgot to add it here

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but didn't test

@GretaD GretaD merged commit 806b648 into main Feb 13, 2025
48 of 49 checks passed
@GretaD GretaD deleted the fix/descr-scrolling branch February 13, 2025 09:18
@GretaD
Copy link
Contributor Author

GretaD commented Feb 13, 2025

/backport to stable5.0

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Feb 13, 2025
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants