Skip to content

feat: migrate to vue3 #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mejo- wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

feat: migrate to vue3 #2279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
b70cf1c
feat: upgrade dependencies to Vue3
mejo- Feb 18, 2026
12e779d
fix(vue): migrate from `Vue.extend()` to `createApp()`
mejo- Feb 18, 2026
610396b
fix(vue): don't use `@<event>.native`
mejo- Feb 18, 2026
5d2a302
fix(vue): migrate `<var>.sync` to `v-model:<var>`
mejo- Feb 18, 2026
1f5f68d
fix(vue): move from `beforeDestroy` to `beforeUnmount`
mejo- Feb 18, 2026
7df8f03
fix(vueRouter): migrate to vue-router 5 syntax
mejo- Feb 18, 2026
872433a
fix(vueRouter): use fullPath for comparison to take query params into…
mejo- Feb 24, 2026
8751bc6
fix(pinia): don't use `Vue.set()` and `this.$set()` and `this.$delete()`
mejo- Feb 18, 2026
7084bec
fix(SkeletonLoading): key attribute in v-for component
mejo- Feb 18, 2026
dffcb8e
fix(sortable): migrate from vuedraggable to vue-draggable-plus
mejo- Feb 18, 2026
6fd33ae
test(playwright): fix typescript type error in create-collective.ts
mejo- Feb 18, 2026
4304e51
chore: migrate to vue3 eslint rules
mejo- Feb 18, 2026
629b04f
fix(vue): declare emitted events in components
mejo- Feb 18, 2026
0cf69c0
fix(PageListItem): call function instead of expression
mejo- Feb 18, 2026
114b53a
fix(SharingEntryLink): don't mutate property
mejo- Feb 18, 2026
528c792
fix(editor): use markRaw for Text editor instances
mejo- Feb 18, 2026
996b468
fix(FilesCollectivesHeader): fix updating path and migrate to typescript
mejo- Feb 24, 2026
9cc8b08
fix(PageInfoBar): pass to Text as custom web component
mejo- Feb 24, 2026
03b2993
fix(vue): use `beforeUnmount` instead of `unmounted` for garbage coll…
mejo- Feb 25, 2026
500de05
fix(NcActions): rename child components to NcAction*
mejo- Feb 25, 2026
2955d93
fix(cypress): in Vue 3, it's `app.config.globalProperties.$router`
mejo- Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cypress/support/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,12 @@ Cypress.Commands.add('enableDashboardWidget', (widgetName) => {
Cypress.Commands.add('routeTo', (path) => {
Cypress.log()
cy.window(silent)
.its('app.$router', silent)
.invoke(silent, 'push', path)
.its('app', silent)
.then((app) => {
// Vue 3: router is on globalProperties
const router = app.$router ?? app.config.globalProperties.$router
return router.push(path)
})
})

Cypress.Commands.add(
Expand Down
4 changes: 2 additions & 2 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

import { recommendedVue2Javascript } from '@nextcloud/eslint-config'
import { recommended } from '@nextcloud/eslint-config'
import { defineConfig } from 'eslint/config'
import pluginCypress from 'eslint-plugin-cypress'

export default defineConfig([
...recommendedVue2Javascript,
...recommended,

{
name: 'cypress',
Expand Down
Loading
Loading