fix(share): use public DAV endpoint v2 for retrieving page content#2292
fix(share): use public DAV endpoint v2 for retrieving page content#2292
Conversation
|
We should also notify people in #1530 after this PR got released, that for those who still experienced the problem, it might be finally solved with the latest release. |
christianlupus
left a comment
There was a problem hiding this comment.
I tested on my instance and it solved the issue for me. @mejo- tested on my instance with this patch cherry-pick-ed successfully.
No maintainer and mo overview over possible side effects
max-nextcloud
left a comment
There was a problem hiding this comment.
Thanks for getting to the root cause of this!
|
Cypress failures seem related though. I suspect the trim is here: collectives/src/components/Page/TextEditor.vue Lines 178 to 180 in ac4d3a2 and for some reason the url does not return any collectives/src/mixins/pageContentMixin.js Lines 39 to 41 in ac4d3a2 |
|
The problem is that this change breaks getting the content of the page in password-protected shares. I'm currently looking into it. |
On some instances, the old public DAV endpoint (`/public.php/webdav/...`) returns 404 for some reason. The new public DAV endpoint v2 (`/public.php/dav/files/<shareToken/...`) works as expected. The files_sharing app uses the new v2 endpoint, so let's use it as well. Fixes: #2257 Signed-off-by: Jonas <jonas@freesources.org>
eed3eb8 to
59f4ea9
Compare
@max-nextcloud and me found the problem. The PR is ready for review again |
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
59f4ea9 to
34fc771
Compare

On some instances, the old public DAV endpoint (
/public.php/webdav/...) returns 404 for some reason. The new public DAV endpoint v2 (/public.php/dav/files/<shareToken/...) works as expected.The files_sharing app uses the new v2 endpoint, so let's use it as well.
Fixes: #2257
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)