Open
Conversation
But place it in the members modal next to the name of the collective, instead of bloating the landing page. Signed-off-by: Peymaneh <peymaneh@posteo.net>
pymnh
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
max-nextcloud
approved these changes
Feb 28, 2026
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Thanks a lot @pymnh !
Code looks good. Design as well. Great idea to follow what's in the dashboard widget.
I did not test it myself though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Initially I wanted to open a ticket to remove the Teams overview from the collectives landing page and move it into the members modal, because I too think that it causes too much confusion there and belongs in the members modal. My wish came partially true in 8c9e829 but now there is no direct link from the collective to its corresponding team overview, which I personally found to be useful.
This PR brings back the link to the team overview that was removed in 8c9e829 , but places it in the members modal next to the name of the collective. This is more intuitive then having it on the landing page: I am already in the members overview and am offered to go "deeper" into the team configuration. The link icon is generally understood as leading to a new page/modal.
🖼️ Screenshots
Notes
The usage of the OpenInNewIcon follows the design of the Teams dashboard widget:
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)has been updated oris not required