fix(PageInfoBar): Do not show versionsLink for public shares#2305
Open
pymnh wants to merge 2 commits intonextcloud:mainfrom
Open
fix(PageInfoBar): Do not show versionsLink for public shares#2305pymnh wants to merge 2 commits intonextcloud:mainfrom
pymnh wants to merge 2 commits intonextcloud:mainfrom
Conversation
Fix in 2430112 was incomplete, should check if can edit **and** if is not a public share. Signed-off-by: Peymaneh <peymaneh@posteo.net>
pymnh
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
mejo-
requested changes
Feb 28, 2026
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Thanks a lot, makes sense indeed! Just one comment, otherwise looks good.
Signed-off-by: Peymaneh <peymaneh@posteo.net>
pymnh
force-pushed
the
fix/do-not-show-version-link-on-public-share
branch
from
a234097 to
4a53522
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)and the changes are covered with testshas been updated oris not required