feat(teams): support federated users/groups search when adding team members

[cristianscheid]

• Related to: 33: federated account from contacts app circles#2303

Summary

Adds possibility to search for federated users (accounts from other instances) and federated groups when adding members to a team in the Contacts app.

Context

• This PR implements the frontend portion. Backend implementation: feat(contacts): support federated users/groups search when adding team members server#57782

Changes

• Enabled federated users and groups in CIRCLES_MEMBER_GROUPING by uncommenting the previously disabled entries in src/models/constants.ts
• Fixed avatar rendering for federated entities: Modified src/components/EntityPicker/EntitySearchResult.vue and src/components/EntityPicker/EntityBubble.vue to conditionally pass the user prop to NcUserBubble only for ShareType.User entities
  • Federated users triggered 404 errors when the component attempted to load avatars from non-existent local paths
  • For non-user share types (federated users, groups, emails), the user prop is set to undefined, causing NcUserBubble to display initials from displayName instead of fetching an avatar
  • This approach was inspired by how it's done on apps/files_sharing/src/components/SharingInput.vue for handling different share types in the Files app external sharing feature

Before

before.webm

After

after.webm

Note

When testing locally, the federated search functionality works correctly (remote users appear in search results). However, when attempting to actually add the remote member to a team, an error occurs indicating the remote instance is unreachable. I believe this is expected behavior when running locally, as a similar error occurs when trying to add an external share in the Files app using the same remote account, which is the reference implementation mentioned in the issue and was not modified in this PR.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

[codecov]

Codecov Report

❌ Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/services/collaborationAutocompletion.js	0.00%	10 Missing and 4 partials ⚠️
src/components/EntityPicker/EntityBubble.vue	0.00%	9 Missing ⚠️
src/components/EntityPicker/EntitySearchResult.vue	0.00%	2 Missing ⚠️
src/components/MemberList/MemberList.vue	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[hamza221]

/backport to stable33

We don't backport feat commits because of conventional app release, Either change the commit to a fix or we can release 8.4.0 once merged.

And contacts app versions are not same as server check here for compatibility with server https://apps.nextcloud.com/apps/contacts

[ArtificialOwl]

we should have a 8.4.0 for 33 only instead of backporting this to 8.3.x

[hamza221]

we should have a 8.4.0 for 33 only instead of backporting this to 8.3.x

this is also doable

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)